Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MODIFY COLUMN of partitioned tables #38297

Open
mjonss opened this issue Oct 4, 2022 · 1 comment · Fixed by #38302 · May be fixed by #40634
Open

Support MODIFY COLUMN of partitioned tables #38297

mjonss opened this issue Oct 4, 2022 · 1 comment · Fixed by #38302 · May be fixed by #40634
Assignees
@mjonss
Labels
component/tablepartition This issue is related to Table Partition of TiDB. type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@mjonss
Copy link
Contributor

mjonss commented Oct 4, 2022

Feature Request

Is your feature request related to a problem? Please describe:

A partitioned table should support the same ALTER commands as a non-partitioned table. But things like MODIFY COLUMN or CHANGE COLUMN does not support partitioned tables.

Describe the feature you'd like:

Support CHANGE COLUMN and MODIFY COLUMN on partitioned tables

Describe alternatives you've considered:

Create a new partitioned table with the changed column, copy all the data. But since there are no trigger support, it is really hard to keep the new table in sync with the old one...

Teachability, Documentation, Adoption, Migration Strategy:

Same as any other CHANGE/MODIFY COLUMN use case, just for partitioned tables.
@mjonss mjonss added type/feature-request Categorizes issue or PR as related to a new feature. component/tablepartition This issue is related to Table Partition of TiDB. labels Oct 4, 2022
@mjonss mjonss self-assigned this Oct 5, 2022
@mjonss mjonss mentioned this issue Oct 5, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Oct 13, 2022
@mjonss
ddl: support modify column on partitioned table (#38302)
af714c2 
close #38297
mjonss added a commit that referenced this issue Oct 13, 2022
@mjonss @xiongjiwei @Yisaer
Merge master into feature branch (#38463)
0d316ef 
* mockkv: make pk id = -1 if no primary key column is used (#38443)

* ddl: support modify column on partitioned table (#38302)

close #38297

* planner: revise isnullRejected check for `And` and `OR` (#38430)

close #38304

Co-authored-by: xiongjiwei <xiongjiwei1996@outlook.com>
Co-authored-by: Song Gao <disxiaofei@163.com>
@mjonss
Copy link
Contributor Author

mjonss commented Dec 22, 2022

This has been reverted by #39991, so I'm reopening this.

@mjonss mjonss reopened this Dec 22, 2022
@mjonss mjonss linked a pull request Jan 16, 2023 that will close this issue
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjonss mjonss

Labels
component/tablepartition This issue is related to Table Partition of TiDB. type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
1 participant
@mjonss