ddl: support modify column on partitioned table #38302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note
|
/run-check_dev |
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
|
/run-check_dev |
Defined2014
approved these changes
Oct 10, 2022
According to review suggestion
|
/run-check_dev |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: a3a5af9
|
ti-chi-bot
added
the
status/can-merge
|
/run-mysql-test |
|
/run-unit-test |
TiDB MergeCI notify✅ Well Done! New fixed [2] after this pr merged.
|
mjonss
added a commit
that referenced
this pull request
Oct 13, 2022
* mockkv: make pk id = -1 if no primary key column is used (#38443) * ddl: support modify column on partitioned table (#38302) close #38297 * planner: revise isnullRejected check for `And` and `OR` (#38430) close #38304 Co-authored-by: xiongjiwei <xiongjiwei1996@outlook.com> Co-authored-by: Song Gao <disxiaofei@163.com>
12 tasks
12 tasks
This was referenced Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #38297
Problem Summary:
Support for partitioned tables was never added for MODIFY COLUMN.
What is changed and how it works?
Removed the limitation and added handling of partitions for the column change DDL operation. Updating indexes was already supported for partitioned tables, so only the table data / rows handling needed to be updated.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.