metric, tikv: record duration for each backoff type #11710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #11710 +/- ##
================================================
+ Coverage 81.4159% 81.4478% +0.0318%
================================================
Files 432 432
Lines 93080 93089 +9
================================================
+ Hits 75782 75819 +37
+ Misses 11876 11855 -21
+ Partials 5422 5415 -7 |
Codecov Report
@@ Coverage Diff @@
## master #11710 +/- ##
================================================
- Coverage 81.4407% 81.4286% -0.0121%
================================================
Files 429 429
Lines 92746 92632 -114
================================================
- Hits 75533 75429 -104
+ Misses 11821 11809 -12
- Partials 5392 5394 +2 |
zz-jason
reviewed
Aug 12, 2019
|
@tiancaiamao @zz-jason PTAL |
|
LGTM |
tiancaiamao
added
status/LGT2
tiancaiamao
added
the
status/can-merge
|
/run-all-tests |
tiancaiamao
approved these changes
Aug 13, 2019
|
cherry pick to release-3.0 in PR #11728 |
|
cherry pick to release-2.1 failed |
zz-jason
pushed a commit
that referenced
this pull request
Aug 16, 2019
sre-bot
pushed a commit
that referenced
this pull request
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
current "KV Errors" - "KV Retry Duration" metrics in grafana only record coprocessor's backoff time.
that miss:
it also miss the fine-gain time for each backoff-type
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
This change is