Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric, tikv: record duration for each backoff type (#11710) #11728

Merged
merged 3 commits into from
Aug 16, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Aug 13, 2019

cherry-pick #11710 to release-3.0


What problem does this PR solve?

current "KV Errors" - "KV Retry Duration" metrics in grafana only record coprocessor's backoff time.

that miss:

  • 2pc commit path's backoff
  • kv get path's backoff

it also miss the fine-gain time for each backoff-type

What is changed and how it works?

  • record backoff duration in backoff
  • remove duplicate cop duration recording

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

  • change metric record

Side effects

  • N/A

Related changes

  • Need to cherry-pick to the release branch

This change is Reviewable

@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 13, 2019

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2019
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 16, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 16, 2019

Sorry @tiancaiamao, you don't have permission to trigger auto merge event on this branch.

@zz-jason zz-jason merged commit 5dab5e7 into pingcap:release-3.0 Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants