planner: consider agg func type in cost model #12038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzmhhh123
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #12038 +/- ##
===========================================
Coverage 81.5318% 81.5318%
===========================================
Files 448 448
Lines 96198 96198
===========================================
Hits 78432 78432
Misses 12192 12192
Partials 5574 5574 |
alivxxx
reviewed
Sep 6, 2019
planner/core/task.go
Outdated
| if numAggFunc == 0 { | ||
| numAggFunc = 1 | ||
| aggFactorSum := 0.0 | ||
| for _, agg := range p.AggFuncs { |
There was a problem hiding this comment.
Why not extract a function for them?
planner/core/task.go
Outdated
| } | ||
| } | ||
| if aggFactorSum == 0 { | ||
| aggFactorSum = 1.0 |
There was a problem hiding this comment.
So no agg func has more cost that single bitXXX? That seems weird.
There was a problem hiding this comment.
My opinion is that bit operation costs lower than other base operations.
winoros
reviewed
Sep 6, 2019
| @@ -43,6 +44,24 @@ const ( | |||
| distinctFactor = 0.8 | |||
| ) | |||
|
|
|||
| var aggFuncFactor = map[string]float64{ | |||
| ast.AggFuncCount: 1.0, | |||
There was a problem hiding this comment.
How do you dicide their values?
And what is defalut for?
There was a problem hiding this comment.
- The values are how they keep the result of their arguments. For example:
avg: avg.sum += expr, avg.cnt += 1
var_pop: var_pop.sum_sqr += expr*expr, var_pop.cnt += 1, var_pop.sum += expr
- The
defaultis just for safety.
lzmhhh123
added
status/can-merge
|
Your auto merge job has been accepted, waiting for #12092 |
This was referenced Sep 9, 2019
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
After PR #11926. We found that aggregation didn't push to cop task for TPCH Q1. The reason is explained by issue #11948. This PR changes the cost model to consider agg function types simply.
What is changed and how it works?
Add factor for each agg function instead of the number of agg functions.
Check List
Tests
Side effects