Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: support display invalid key in stats buckets #12064

Merged
merged 2 commits into from
Sep 9, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Sep 6, 2019

What problem does this PR solve?

show stats_buckets sometimes shows errors like invalid encoded key flag 252.

What is changed and how it works?

Feedback may generate invalid index keys, we need to handle these when trying to display values instead of raise errors.

Check List

Tests

  • Unit test
    Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • support display invalid keys that may be generated by feedback in show stats_buckets

@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #12064 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12064   +/-   ##
===========================================
  Coverage   81.5184%   81.5184%           
===========================================
  Files           448        448           
  Lines         96123      96123           
===========================================
  Hits          78358      78358           
  Misses        12189      12189           
  Partials       5576       5576

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lzmhhh123 lzmhhh123 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Sep 9, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 9, 2019

Your auto merge job has been accepted, waiting for #12092, #12038, #12093

@sre-bot
Copy link
Contributor

sre-bot commented Sep 9, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 9, 2019

cherry pick to release-3.0 in PR #12094

@sre-bot
Copy link
Contributor

sre-bot commented Sep 9, 2019

cherry pick to release-2.1 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/statistics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants