ddl: fix drop index failed when index contain auto_increment column and more than 2 index contain auto_increment_column #12230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd more than 2 index contain auto_increment_column
Codecov Report
@@ Coverage Diff @@
## master #12230 +/- ##
================================================
+ Coverage 81.0765% 81.3147% +0.2382%
================================================
Files 454 457 +3
Lines 99247 101647 +2400
================================================
+ Hits 80466 82654 +2188
- Misses 12963 13138 +175
- Partials 5818 5855 +37 |
zimulala
reviewed
Sep 17, 2019
ddl/ddl_api.go
Outdated
| continue | ||
| } | ||
| count++ | ||
| break |
There was a problem hiding this comment.
I think we can change this code as follows:
if c.Name.L == colName {
count++
break
}
zimulala
reviewed
Sep 17, 2019
ddl/ddl_api.go
Outdated
| @@ -3422,6 +3423,20 @@ func (d *ddl) DropIndex(ctx sessionctx.Context, ti ast.Ident, indexName model.CI | |||
| return errors.Trace(err) | |||
| } | |||
|
|
|||
| func countOfIndexContainColumn(tblInfo *model.TableInfo, colName string) int { | |||
There was a problem hiding this comment.
Could we put this function to index.go?
| cols := t.Cols() | ||
| for _, idxCol := range indexInfo.Columns { | ||
| if mysql.HasAutoIncrementFlag(cols[idxCol.Offset].Flag) { | ||
| if mysql.HasAutoIncrementFlag(cols[idxCol.Offset].Flag) && countOfIndexContainColumn(t.Meta(), idxCol.Name.L) < 2 { | ||
| return autoid.ErrWrongAutoKey | ||
| } | ||
| } |
There was a problem hiding this comment.
Could we extract this code(line3400-3405) directly into a function instead of using countOfIndexContainColumn ?
bb7133
added
status/LGT1
AilinKid
added
status/LGT3
AilinKid
added
status/LGT2
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 in PR #12344 |
|
cherry pick to release-3.1 in PR #12345 |
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @crazycs520 PTAL. |
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Apr 9, 2020
…nd more than 2 index contain auto_increment_column (pingcap#12230) Signed-off-by: crazycs520 <crazycs520@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release note
drop indexon auto_increment column failed when table has more than 2 indexes that contain auto_increment column.