planner: prune cop task for tiflash #13131
Conversation
|
|
|
|
Codecov Report
@@ Coverage Diff @@
## master #13131 +/- ##
================================================
- Coverage 80.2509% 80.0811% -0.1698%
================================================
Files 469 468 -1
Lines 111823 110890 -933
================================================
- Hits 89739 88802 -937
- Misses 15190 15221 +31
+ Partials 6894 6867 -27 |
|
@windtalker please add some proper labels for this pr |
| @@ -1035,9 +1035,10 @@ func (ds *DataSource) getOriginalPhysicalTableScan(prop *property.PhysicalProper | |||
| ts.StoreType = kv.TiKV | |||
| } | |||
| if ts.StoreType == kv.TiFlash { | |||
| // append the AccessCondition to filterCondition because TiFlash only support full range scan for each | |||
| // region, do not reset ts.Ranges as it will help prune regions during `buildCopTasks` | |||
There was a problem hiding this comment.
Since it's a full range scan. Which task is pruned before?
There was a problem hiding this comment.
For example, for a table t with id as its primary key, and the id is the handle column, if user fire a query like select count(*) from t where id >= 100, then obviously, only some of the regions have the useful data. For TiKV, TiDB will only send the cop request to these regions, this "task prune" is done by passing range [100, +inf) to the buildCopTask function. For TiFlash, although it requires full range scan on every region, we can still prune the task which is sending cop request to the regions that do not have data with id >= 100
Co-Authored-By: Yiding Cui <winoros@gmail.com>
…ker/tidb into prune_region_for_tiflash
Co-Authored-By: Zhuomin(Charming) Liu <lzmhhh123@gmail.com>
lzmhhh123
added
status/can-merge
|
/run-all-tests |
|
@windtalker please follow Commit Message and Pull Request Style Commit Message and Pull Request Style to reformat the PR title. |
|
@windtalker merge failed. |
windtalker
changed the title
|
/run-integration-common-test |
What problem does this PR solve?
prune unnecessary cop task when TiDB query TiFlash
What is changed and how it works?
when pk is handle and the query has filter on the pk column, TiDB use cop ranges to prune the unnecessary cop task, but for TiFlash, since TiFlash does not support scan range in cop task, so current code always use full range to build the cop task. In this pr, the cop ranges is enabled for TiFlash to prune cop task, and in
buildCopTasks, it will use the full region range when generating TiFlash cop task.Check List
Tests
Side effects