-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: prune cop task for tiflash #13131
Merged
lzmhhh123
merged 17 commits into
pingcap:master
from
windtalker:prune_region_for_tiflash
Nov 7, 2019
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
60bb86b
prune region for tiflash
windtalker 9b51430
add tests
windtalker 6972d45
merge master
windtalker 74527ac
Merge branch 'master' into prune_region_for_tiflash
windtalker bb9db53
update test reference && format code
windtalker 7e9effc
Merge branch 'prune_region_for_tiflash' of https://github.com/windtal…
windtalker 350bf77
do not change the range info in explain output
windtalker 5b02d47
Update planner/core/find_best_task.go
windtalker d2d25d7
address comments
windtalker e4ac355
Merge branch 'prune_region_for_tiflash' of https://github.com/windtal…
windtalker 92e2c5c
Merge branch 'master' into prune_region_for_tiflash
windtalker c06a062
Merge branch 'master' into prune_region_for_tiflash
windtalker 33024c8
Merge branch 'master' into prune_region_for_tiflash
windtalker 91367f2
Update planner/core/explain.go
windtalker cda2836
address comments
windtalker 367bd35
format code
windtalker 68334e7
Merge branch 'master' into prune_region_for_tiflash
sre-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's a full range scan. Which task is pruned before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example, for a table t with id as its primary key, and the id is the handle column, if user fire a query like
select count(*) from t where id >= 100
, then obviously, only some of the regions have the useful data. For TiKV, TiDB will only send the cop request to these regions, this "task prune" is done by passing range [100, +inf) to thebuildCopTask
function. For TiFlash, although it requires full range scan on every region, we can still prune the task which is sending cop request to the regions that do not have data withid >= 100