-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: add more retryable error for retryer #43022
Conversation
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/check-issue-triage-complete |
@@ -194,11 +194,11 @@ func (bo *pdReqBackoffer) NextBackoff(err error) time.Duration { | |||
// bo.attempt-- | |||
e := errors.Cause(err) | |||
switch e { // nolint:errorlint | |||
case nil, context.Canceled, context.DeadlineExceeded, io.EOF, sql.ErrNoRows: | |||
case nil, context.Canceled, context.DeadlineExceeded, sql.ErrNoRows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd better to figure out why io.EOF
isn't retryable from beginning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess just move code from lightning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a test case here?
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 093b38e
|
/hold |
/merge |
/unhold |
/retest |
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4642cca
|
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9436bd1
|
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 19f8d3e
|
/retest |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #42909
Problem Summary:
some error is retryable, such as:
io.EOF
for getting ts from PDread: connection reset
for connecting to s3What is changed and how it works?
modify the
shouldRetry
logicCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.