Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: add more retryable error for retryer (#43022) #43611

Merged
merged 4 commits into from
Jun 26, 2023
Merged

br: add more retryable error for retryer (#43022) #43611

merged 4 commits into from
Jun 26, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #43022

What problem does this PR solve?

Issue Number: close #42909

Problem Summary:
some error is retryable, such as:

  1. io.EOF for getting ts from PD
  2. read: connection reset for connecting to s3

What is changed and how it works?

modify the shouldRetry logic

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Leavrth @ti-chi-bot
This is an automated cherry-pick of pingcap#43022
6491990 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 8, 2023
Merged
12 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 8, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Leavrth

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels May 8, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 8, 2023
@Leavrth
resolve conflicts
3b2c756 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 24, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2023
@Leavrth
Copy link
Contributor

Leavrth commented May 25, 2023

/retest

1 similar comment
@Leavrth
Copy link
Contributor

Leavrth commented May 25, 2023

/retest

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 25, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jun 5, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 26, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-05 03:33:32.761340117 +0000 UTC m=+232799.034312886: ☑️ agreed by hawkingrei.
  • 2023-06-26 10:32:36.429188307 +0000 UTC m=+617321.830438756: ☑️ agreed by Leavrth.

@Leavrth
Copy link
Contributor

Leavrth commented Jun 26, 2023

/retest

3 similar comments
@Leavrth
Copy link
Contributor

Leavrth commented Jun 26, 2023

/retest

@Leavrth
Copy link
Contributor

Leavrth commented Jun 26, 2023

/retest

@Leavrth
Copy link
Contributor

Leavrth commented Jun 26, 2023

/retest

@Leavrth
fix unit test
eff937d 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
fix unit test
7d3eb7c 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor

Leavrth commented Jun 26, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 464dc82 into pingcap:release-6.5 Jun 26, 2023
4 checks passed
@Leavrth Leavrth mentioned this pull request Jul 21, 2023
Closed
@BornChanger BornChanger mentioned this pull request Aug 22, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@Leavrth Leavrth Leavrth approved these changes

Assignees

@Leavrth Leavrth

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @Leavrth @hawkingrei @VelocityLight