*: avoid concurrently using the session in the syncload #52830
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52830 +/- ##
================================================
+ Coverage 72.3201% 75.6685% +3.3483%
================================================
Files 1474 1478 +4
Lines 427611 432436 +4825
================================================
+ Hits 309249 327218 +17969
+ Misses 99057 85068 -13989
- Partials 19305 20150 +845
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| task1.Retry = 0 | ||
| for i := 0; i < syncload.RetryCount*5; i++ { | ||
| task1, err1 = h.HandleOneTask(testKit.Session().(sessionctx.Context), task1, exitCh) | ||
| require.Error(t, err1) |
There was a problem hiding this comment.
It failpoints a panic in the program. so HandleOneTask can quickly exit and create many goroutine in the tests.
[LGTM Timeline notifier]Timeline:
|
|
/hold wait for test result from QA. |
ti-chi-bot
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, lcwangchao, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
|
|
/retest |
|
/cherrypick release-8.1 |
|
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/cherrypick release-7.5 |
|
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
/cherrypick release-7.1 |
|
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #52827
Problem Summary:
What changed and how does it work?
when
singleflightmeets timeout, some goroutines will concurrently use reuse session. we should keep everyone using independent sessions.Check List
Tests
run it in the HA, It can pass test.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.