-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: avoid concurrently using the session in the syncload (#52830) #53331
*: avoid concurrently using the session in the syncload (#52830) #53331
Conversation
0c7790d
to
008a67e
Compare
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
008a67e
to
52eb1a3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #53331 +/- ##
================================================
Coverage ? 71.9949%
================================================
Files ? 1411
Lines ? 409855
Branches ? 0
================================================
Hits ? 295075
Misses ? 94919
Partials ? 19861
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #52830
What problem does this PR solve?
Issue Number: close #52827
Problem Summary:
What changed and how does it work?
when
singleflight
meets timeout, some goroutines will concurrently use reuse session. we should keep everyone using independent sessions.Check List
Tests
run it in the HA, It can pass test.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.