ticdc/token-region: don't set metric to 0 since multiple tables share…

… it (#3480) (#4290)
pingcap · Jan 21, 2022 · f01d506 · f01d506
1 parent 01c8373
commit f01d506
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/cdc/kv/token_region.go b/cdc/kv/token_region.go
@@ -104,7 +104,6 @@ func (r *sizedRegionRouter) AddRegion(sri singleRegionInfo) {
 		r.buffer[id] = append(r.buffer[id], sri)
 		if _, ok := r.metrics.cachedRegions[id]; !ok {
 			r.metrics.cachedRegions[id] = cachedRegionSize.WithLabelValues(id, r.metrics.changefeed, r.metrics.capture)
-			r.metrics.cachedRegions[id].Set(0)
 		}
 		r.metrics.cachedRegions[id].Inc()
 	}
@@ -119,7 +118,6 @@ func (r *sizedRegionRouter) Acquire(id string) {
 	r.tokens[id]++
 	if _, ok := r.metrics.tokens[id]; !ok {
 		r.metrics.tokens[id] = clientRegionTokenSize.WithLabelValues(id, r.metrics.changefeed, r.metrics.capture)
-		r.metrics.tokens[id].Set(0)
 	}
 	r.metrics.tokens[id].Inc()
 }
@@ -132,7 +130,6 @@ func (r *sizedRegionRouter) Release(id string) {
 	r.tokens[id]--
 	if _, ok := r.metrics.tokens[id]; !ok {
 		r.metrics.tokens[id] = clientRegionTokenSize.WithLabelValues(id, r.metrics.changefeed, r.metrics.capture)
-		r.metrics.tokens[id].Set(0)
 	}
 	r.metrics.tokens[id].Dec()
 }
@@ -143,8 +140,8 @@ func (r *sizedRegionRouter) Run(ctx context.Context) error {
 		ticker.Stop()
 		r.lock.Lock()
 		defer r.lock.Unlock()
-		for _, m := range r.metrics.cachedRegions {
-			m.Set(0)
+		for id, buf := range r.buffer {
+			r.metrics.cachedRegions[id].Sub(float64(len(buf)))
 		}
 	}()
 	for {