Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc/token-region: don't set metric to 0 since multiple tables share it #3480

Merged
merged 11 commits into from
Jan 12, 2022
Merged

ticdc/token-region: don't set metric to 0 since multiple tables share it #3480

merged 11 commits into from
Jan 12, 2022

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Metrics in token region are shared by multiple tables, so we should not use set to a set specific value

What is changed and how it works?

Use accurate inc or dec instead

Check List

Tests

  • Unit test
  • Integration test

Release note 

Fix kv client cached region metric could be negative.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • ben1009

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 16, 2021
@amyangfei amyangfei added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. labels Nov 16, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2021
@amyangfei amyangfei added component/metrics-logging Metrics and logging component. area/ticdc Issues or PRs related to TiCDC. status/ptal Could you please take a look? and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2021
@amyangfei
Copy link
Contributor Author

/run-all-tests

@maxshuang
Copy link
Contributor

I test this pr, look good.

amyangfei
amyangfei commented Dec 28, 2021
View reviewed changes
cdc/kv/token_region.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 11, 2022
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 11, 2022
@amyangfei amyangfei added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Jan 11, 2022
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bc49052

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 11, 2022
@amyangfei
Copy link
Contributor Author

/run-verify
/run-kafka-integration-test

@amyangfei
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit 9261014 into pingcap:master Jan 12, 2022
@amyangfei amyangfei deleted the fix-cached-region-metric branch January 12, 2022 06:08
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 12, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4290.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 12, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4291.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 12, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4292.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 12, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4293.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 12, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4294.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 12, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4295.

@overvenus
Copy link
Member

Cc #4300

overvenus pushed a commit that referenced this pull request Jan 12, 2022
@ti-chi-bot @amyangfei
ticdc/token-region: don't set metric to 0 since multiple tables share…
ef9c22d 
… it (#3480) (#4291)

* ticdc/token-region: don't set metric to 0 since multiple tables share it

* Update cdc/kv/token_region.go

Co-authored-by: amyangfei <amyangfei@gmail.com>
ti-chi-bot added a commit that referenced this pull request Jan 19, 2022
@ti-chi-bot
ticdc/token-region: don't set metric to 0 since multiple tables share…
8934515 
… it (#3480) (#4294)
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Jan 20, 2022
@amyangfei @zhaoxinyu
ticdc/token-region: don't set metric to 0 since multiple tables share…
c4e1451 
… it (pingcap#3480)
ti-chi-bot added a commit that referenced this pull request Jan 21, 2022
@ti-chi-bot
ticdc/token-region: don't set metric to 0 since multiple tables share…
f01d506 
… it (#3480) (#4290)
ti-chi-bot added a commit that referenced this pull request Feb 23, 2022
@ti-chi-bot
ticdc/token-region: don't set metric to 0 since multiple tables share…
07968b7 
… it (#3480) (#4295)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben1009 ben1009 ben1009 approved these changes

@asddongmen asddongmen asddongmen approved these changes

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/metrics-logging Metrics and logging component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amyangfei @ti-chi-bot @maxshuang @overvenus @ben1009 @asddongmen