Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv client cached region metric could be negative #4300

Closed
overvenus opened this issue Jan 12, 2022 · 0 comments · Fixed by #4291
Closed

kv client cached region metric could be negative #4300

overvenus opened this issue Jan 12, 2022 · 0 comments · Fixed by #4291
Labels
affects-4.0 affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 area/ticdc Issues or PRs related to TiCDC. component/kv-client TiKV kv log client component. component/metrics-logging Metrics and logging component. severity/minor type/bug The issue is confirmed as a bug.

Comments

@overvenus
Copy link
Member

What did you do?

As title.

What did you expect to see?

No response

What did you see instead?

Should not be negative.

Versions of the cluster

TiCDC version (execute cdc version):

750816fd986e42aad5c00d711850093e8c3a5a23
@overvenus overvenus added type/bug The issue is confirmed as a bug. component/kv-client TiKV kv log client component. severity/minor component/metrics-logging Metrics and logging component. area/ticdc Issues or PRs related to TiCDC. labels Jan 12, 2022
This was referenced Jan 12, 2022
Merged
Merged
@overvenus overvenus linked a pull request Jan 12, 2022 that will close this issue
ticdc/token-region: don't set metric to 0 since multiple tables share it (#3480) #4291
Merged
This was referenced Jan 12, 2022
Merged
Merged
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-4.0 affects-5.0 affects-5.1 affects-5.2 affects-5.3 affects-5.4 area/ticdc Issues or PRs related to TiCDC. component/kv-client TiKV kv log client component. component/metrics-logging Metrics and logging component. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ticdc/token-region: don't set metric to 0 since multiple tables share it (#3480) ti-chi-bot/tiflow
2 participants
@overvenus @jebter