-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ticdc/token-region: don't set metric to 0 since multiple tables share it (#3480) #4293
ticdc/token-region: don't set metric to 0 since multiple tables share it (#3480) #4293
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## release-5.0 #4293 +/- ##
================================================
Coverage ? 62.0671%
================================================
Files ? 161
Lines ? 16893
Branches ? 0
================================================
Hits ? 10485
Misses ? 5500
Partials ? 908 |
Cc #4300 |
This is an automated cherry-pick of #3480
What problem does this PR solve?
Metrics in token region are shared by multiple tables, so we should not use
set
to a set specific valueWhat is changed and how it works?
Use accurate inc or dec instead
Check List
Tests
Release note