Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc/token-region: don't set metric to 0 since multiple tables share it (#3480) #4291

Merged
merged 2 commits into from
Jan 12, 2022
Merged

ticdc/token-region: don't set metric to 0 since multiple tables share it (#3480) #4291

merged 2 commits into from
Jan 12, 2022

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jan 12, 2022 •
edited by overvenus
Loading

This is an automated cherry-pick of #3480

What problem does this PR solve?

Metrics in token region are shared by multiple tables, so we should not use set to a set specific value

Close #4300

What is changed and how it works?

Use accurate inc or dec instead

Check List

Tests

  • Unit test
  • Integration test

Release note 

Fix kv client cached region metric could be negative.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ticdc Issues or PRs related to TiCDC. component/metrics-logging Metrics and logging component. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. labels Jan 12, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 12, 2022
Merged
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. label Jan 12, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 12, 2022
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 33b3989

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 12, 2022
@overvenus overvenus added this to the v5.4.0 milestone Jan 12, 2022
@overvenus
Copy link
Member

/run-unit-test

@overvenus overvenus linked an issue Jan 12, 2022 that may be closed by this pull request
kv client cached region metric could be negative #4300
Closed
@amyangfei
Copy link
Contributor

/run-unit-test

@amyangfei
Copy link
Contributor

/run-leak-test

@overvenus
Copy link
Member

/run-unit-test

@overvenus overvenus merged commit ef9c22d into pingcap:release-5.4 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amyangfei amyangfei

Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. component/metrics-logging Metrics and logging component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Milestone
v5.4.0
Development

Successfully merging this pull request may close these issues.

kv client cached region metric could be negative
4 participants
@ti-chi-bot @overvenus @amyangfei @VelocityLight