Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner(ticdc): Add support for region-label to enable meta-region isolation #4937

Merged
merged 9 commits into from
May 7, 2022
Merged

owner(ticdc): Add support for region-label to enable meta-region isolation #4937

merged 9 commits into from
May 7, 2022

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Mar 17, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4756 close #4762
TiDB related issues, ref: pingcap/tidb#33665

What is changed and how it works?

  1. Add new pdutil pkg to support region label
  2. Verify meta-related label rules when init upstream

image

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to update the documentation

Release note 

`Add support for region-label to enable meta-region isolation`

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 17, 2022
@CharlesCheung96 CharlesCheung96 requested review from overvenus and amyangfei and removed request for overvenus March 17, 2022 11:12
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 17, 2022
overvenus
overvenus reviewed Mar 17, 2022
View reviewed changes
pkg/placement/placement_client.go Outdated Show resolved Hide resolved
pkg/placement/placement_client.go Outdated Show resolved Hide resolved
pkg/placement/placement_client.go Outdated Show resolved Hide resolved
pkg/placement/placement_client.go Outdated Show resolved Hide resolved
pkg/placement/placement_client.go Outdated Show resolved Hide resolved
pkg/placement/placement_client.go Outdated Show resolved Hide resolved
pkg/placement/placement_client.go Outdated Show resolved Hide resolved
pkg/placement/placement_client.go Outdated Show resolved Hide resolved
pkg/placement/placement_client.go Outdated Show resolved Hide resolved
pkg/placement/placement_client.go Outdated Show resolved Hide resolved
@overvenus
Copy link
Member

Could you reorg pd packages? E.g.,

├── pkg
│   ├── pdutil
│   │   ├── placement
│   │   ├── clock (former `pdtime`)

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 21, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 21, 2022
@CharlesCheung96
Copy link
Contributor Author

Could you reorg pd packages? E.g.,

├── pkg
│   ├── pdutil
│   │   ├── placement
│   │   ├── clock (former `pdtime`)

Is this more appropriate?

├── pkg
│   ├── pdutil
│   │   ├── placement_client.go
│   │   ├── clock.go

@overvenus
Copy link
Member

Could you reorg pd packages? E.g.,

├── pkg
│   ├── pdutil
│   │   ├── placement
│   │   ├── clock (former `pdtime`)

Is this more appropriate?

├── pkg
│   ├── pdutil
│   │   ├── placement_client.go
│   │   ├── clock.go

Sure, looks good to me!

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2022
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2022
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

3 similar comments
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

amyangfei
amyangfei reviewed Mar 22, 2022
View reviewed changes
pkg/pdutil/placement_client.go Outdated Show resolved Hide resolved
cdc/capture/capture.go Outdated Show resolved Hide resolved
cdc/capture/capture.go Outdated Show resolved Hide resolved
cdc/capture/capture.go Outdated Show resolved Hide resolved
pkg/pdutil/placement_client.go Outdated Show resolved Hide resolved
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

1 similar comment
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-verify
/run-kafka-integration-test

@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 48781ba

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 7, 2022
@CharlesCheung96
Copy link
Contributor Author

/run-verify
/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit dadad88 into pingcap:master May 7, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 7, 2022
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#4937
55f3e98 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 7, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5353.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 7, 2022
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#4937
35c1288 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 7, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5354.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 7, 2022
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#4937
37adc9a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5355.

@ti-chi-bot ti-chi-bot mentioned this pull request May 7, 2022
Closed
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request May 7, 2022
@CharlesCheung96
owner(ticdc): Add support for region-label to enable meta-region isol…
0509638 
…ation (pingcap#4937)

    close pingcap#4756, close pingcap#4762
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request May 7, 2022
@CharlesCheung96
owner(ticdc): Add support for region-label to enable meta-region isol…
e0be6e8 
…ation (pingcap#4937)

    close pingcap#4756, close pingcap#4762
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request May 7, 2022
@CharlesCheung96
owner(ticdc): Add support for region-label to enable meta-region isol…
bbe7c3b 
…ation (pingcap#4937)

    close pingcap#4756, close pingcap#4762
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request May 7, 2022
@CharlesCheung96
owner(ticdc): Add support for region-label to enable meta-region isol…
6981429 
…ation (pingcap#4937)

    close pingcap#4756, close pingcap#4762
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request May 7, 2022
@CharlesCheung96
owner(ticdc): Add support for region-label to enable meta-region isol…
4a07cb7 
…ation (pingcap#4937)

    close pingcap#4756, close pingcap#4762
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request May 7, 2022
@CharlesCheung96
owner(ticdc): Add support for region-label to enable meta-region isol…
5fbb966 
…ation (pingcap#4937)

    close pingcap#4756, close pingcap#4762
@nongfushanquan
Copy link
Contributor

/label affects-5.3

CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jun 20, 2022
@CharlesCheung96
owner(ticdc): Add support for region-label to enable meta-region isol…
de66f59 
…ation (pingcap#4937)

    close pingcap#4756, close pingcap#4762
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jun 21, 2022
@CharlesCheung96
owner(ticdc): Add support for region-label to enable meta-region isol…
61bb40c 
…ation (pingcap#4937)

    close pingcap#4756, close pingcap#4762
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Jun 21, 2022
@CharlesCheung96
owner(ticdc): Add support for region-label to enable meta-region isol…
789cc8b 
…ation (pingcap#4937)

    close pingcap#4756, close pingcap#4762
ti-chi-bot added a commit that referenced this pull request Jun 21, 2022
@ti-chi-bot
owner(ticdc): Add support for region-label to enable meta-region isol…
01dc212 
…ation (#4937) (#5353)

close #4756, close #4762
ti-chi-bot added a commit that referenced this pull request Jun 22, 2022
@ti-chi-bot
owner(ticdc): Add support for region-label to enable meta-region isol…
7575662 
…ation (#4937) (#5354)

close #4756, close #4762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen left review comments

@amyangfei amyangfei amyangfei approved these changes

@overvenus overvenus overvenus approved these changes

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
affects-5.3 area/ticdc Issues or PRs related to TiCDC. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meta region leader transfer may cause latency spike Meta region merge may cause latency spike
9 participants
@CharlesCheung96 @ti-chi-bot @overvenus @codecov-commenter @CLAassistant @asddongmen @nongfushanquan @amyangfei @nolouch