Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner(ticdc): Add support for region-label to enable meta-region isolation (#4937) #5353

Merged
merged 1 commit into from
Jun 21, 2022
Merged

owner(ticdc): Add support for region-label to enable meta-region isolation (#4937) #5353

merged 1 commit into from
Jun 21, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4937

What problem does this PR solve?

Issue Number: close #4756 close #4762
TiDB related issues, ref: pingcap/tidb#33665

What is changed and how it works?

  1. Add new pdutil pkg to support region label
  2. Verify meta-related label rules when init upstream

image

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to update the documentation

Release note 

`Add support for region-label to enable meta-region isolation`

@ti-chi-bot ti-chi-bot mentioned this pull request May 7, 2022
Merged
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved area/ticdc Issues or PRs related to TiCDC. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR. labels May 7, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 7, 2022
@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-4937-to-release-5.3 branch from 55f3e98 to bbe7c3b Compare May 7, 2022 10:00
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 7, 2022
@CharlesCheung96
Copy link
Contributor

/run-all-tests

@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-4937-to-release-5.3 branch from bbe7c3b to 6981429 Compare May 7, 2022 13:25
@CharlesCheung96
Copy link
Contributor

/run-all-tests

@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-4937-to-release-5.3 branch 2 times, most recently from 4a07cb7 to 5fbb966 Compare May 7, 2022 13:50
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.3@022c581). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.3      #5353   +/-   ##
================================================
  Coverage               ?   55.8304%           
================================================
  Files                  ?        223           
  Lines                  ?      23849           
  Branches               ?          0           
================================================
  Hits                   ?      13315           
  Misses                 ?       9183           
  Partials               ?       1351

@nongfushanquan
Copy link
Contributor

/label affects-5.3

@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 16, 2022
@CharlesCheung96
Copy link
Contributor

/run-all-tests

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 56bcf38

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2022
@CharlesCheung96
Copy link
Contributor

/run-uint-test

@CharlesCheung96
Copy link
Contributor

/run-verify
/run-leak-test

@CharlesCheung96
Copy link
Contributor

/run-all-tests

@CharlesCheung96
Copy link
Contributor

/run-kafka-integration-test
/run-verify

@CharlesCheung96
Copy link
Contributor

/run-all-tests

@CharlesCheung96
Copy link
Contributor

/run-kafka-integration-test
/run-unit-test
/run-leak-test

@nongfushanquan
Copy link
Contributor

/run-kafka-integration-test

3 similar comments
@nongfushanquan
Copy link
Contributor

/run-kafka-integration-test

@CharlesCheung96
Copy link
Contributor

/run-kafka-integration-test

@zhaoxinyu
Copy link
Contributor

/run-kafka-integration-test

@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-4937-to-release-5.3 branch from afbf716 to de66f59 Compare June 20, 2022 10:38
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 20, 2022
@CharlesCheung96
Copy link
Contributor

/run-kafka-integration-test

@ti-chi-bot
Copy link
Member Author

@CharlesCheung96: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: de66f59

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2022
@CharlesCheung96
Copy link
Contributor

/run-unit-test

1 similar comment
@CharlesCheung96
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 01dc212 into pingcap:release-5.3 Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CharlesCheung96 CharlesCheung96

Labels
affects-5.3 area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-chi-bot @CharlesCheung96 @codecov-commenter @nongfushanquan @amyangfei @zhaoxinyu @asddongmen @sre-bot