Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS X Support Broke Carthage #140

Closed
justin opened this issue Feb 11, 2016 · 13 comments
Closed

OS X Support Broke Carthage #140

justin opened this issue Feb 11, 2016 · 13 comments

Comments

@justin
Copy link
Contributor

justin commented Feb 11, 2016

When I try to use a freshly built copy of the framework from master, it gets mad about the PINImage defines saying it can't find them.

It builds fine in the PINRemoteImage project, but importing it into a third-party iOS app causes tons of errors around the define breaking down.

I wonder if frameworks can't deduce the #define values? I can't really find any documentation to validate or invalidate this.
@justin
Copy link
Contributor Author

justin commented Feb 11, 2016

If you copy-pasta the defines into each class that use them rather than just the import of PINRemoteImageMacros, it's fine. Obviously not an ideal solution. Trying to see what else is feasible.

@garrettmoon
Copy link
Collaborator

@justin thanks for looking into it! Let me know if I can help in any way.

@garrettmoon garrettmoon reopened this Feb 11, 2016
@justin
Copy link
Contributor Author

justin commented Feb 11, 2016

Maybe @maicki can chime in with some thoughts since he spearheaded the OS X support.

@maicki
Copy link
Collaborator

maicki commented Mar 14, 2016

@justin @garrettmoon Can we close that issue due to: #160 ?

@justin
Copy link
Contributor Author

justin commented Mar 15, 2016

Let me dig into it today. I'll report back.

@justin
Copy link
Contributor Author

justin commented Mar 15, 2016

This is still an issue, with the same errors coming back.

screen shot 2016-03-15 at 12 32 53 pm

@justin
Copy link
Contributor Author

justin commented Mar 15, 2016

This branch fixes it I believe.

https://github.com/justin/PINRemoteImage/tree/fix/osx-conditionals

I updated the conditionals to be more explicit and added an import of TargetConditionals.h in the macros file. Stuff compiles now.

Computers!

@garrettmoon
Copy link
Collaborator

Computers! Mind putting up a pull request?

@justin
Copy link
Contributor Author

justin commented Mar 17, 2016

Yessir! #164

@garrettmoon
Copy link
Collaborator

Landed!

@justin
Copy link
Contributor Author

justin commented Mar 19, 2016

Whoooo. Would be nice if it became a 2.1.1 so we could get back on mainline. We're still tagged at 1.2.3

@garrettmoon
Copy link
Collaborator

Absolutely, I'll try and get this released over the weekend (ping this thread if I forget).

@garrettmoon
Copy link
Collaborator

Published 2.1.1

tinder-garricnahapetian pushed a commit to TinderApp/PINRemoteImage that referenced this issue Mar 22, 2024
@garrettmoon
Increase max operation count to 10 (pinterest#140)
36b21b4 
On lower end devices most operations end up being empty trash operations.
That issue needs to be addressed, but in the meantime, lets bump this
number up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justin @maicki @garrettmoon