Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Example-Mac and Carthage support #160

Merged

Conversation

ikesyo
Copy link
Contributor

@ikesyo ikesyo commented Mar 10, 2016

Fixes Carthage/Carthage#1179.

There is an invalid Pods-PINRemoteImage-PINRemoteImage.xcscheme scheme which does not have corresponding build target.

There is an invalid `Pods-PINRemoteImage-PINRemoteImage.xcscheme` scheme which does not have corresponding build target.
@ikesyo ikesyo force-pushed the fix-mac-example-and-carthage-support branch from 84193fd to 9109ff5 Compare March 11, 2016 15:05
@ikesyo
Copy link
Contributor Author

ikesyo commented Mar 11, 2016

Rebased.

@garrettmoon
Copy link
Collaborator

Thanks @ikesyo !

garrettmoon added a commit that referenced this pull request Mar 12, 2016
@garrettmoon garrettmoon merged commit 2214c0e into pinterest:master Mar 12, 2016
@ikesyo ikesyo deleted the fix-mac-example-and-carthage-support branch March 12, 2016 05:03
tinder-garricnahapetian pushed a commit to TinderApp/PINRemoteImage that referenced this pull request Mar 22, 2024
* Migrate to using external PINOperation

* Update things

* Remove contentious option

* Switch to Carthage, rejigger folder structure

* Point to PINOperation 1.0.2

* Update

* Update Carthage

* Update build scripts

* Remove dead script

* Update buck file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants