Fixes a crash in task callbacks #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While all methods on tasks are called within the manager's lock, dispatching to another queue obviously means the manager may not be locked anymore. I also moved calling progress download callbacks to the download task so it's similar to progress image. Hopefully these issues have been fixed, but it leads me to believe a better architecture would be to make the tasks immutable by the manager and have the tasks manage a lock on themselves. I'll need to think about that more.
|
@maicki Mind taking a look at this PR, I moved some of your code. |
|
@garrettmoon looks good to me! |
garrettmoon
added a commit
that referenced
this pull request
Feb 23, 2016
Fixes a crash in task callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While all methods on tasks are called within the manager's lock,
dispatching to another queue obviously means the manager may not
be locked anymore.
I also moved calling progress download callbacks to the download
task so it's similar to progress image.
Hopefully these issues have been fixed, but it leads me to believe
a better architecture would be to make the tasks immutable by the
manager and have the tasks manage a lock on themselves. I'll need
to think about that more.