Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a crash in task callbacks #148

Merged
merged 3 commits into from
Feb 23, 2016
Merged

Fixes a crash in task callbacks #148

merged 3 commits into from
Feb 23, 2016

Commits on Feb 23, 2016

  1. Fixes a crash in task callbacks 

    While all methods on tasks are called within the manager's lock,
dispatching to another queue obviously means the manager may not
be locked anymore.

I also moved calling progress download callbacks to the download
task so it's similar to progress image.

Hopefully these issues have been fixed, but it leads me to believe
a better architecture would be to make the tasks immutable by the
manager and have the tasks manage a lock on themselves. I'll need
to think about that more.
    @garrettmoon
    garrettmoon committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    29b0b4a View commit details
    Browse the repository at this point in the history

  2. All access to callback should be done outside async

    @garrettmoon
    garrettmoon committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    dea281b View commit details
    Browse the repository at this point in the history

  3. Added comments

    @garrettmoon
    garrettmoon committed Feb 23, 2016
    Configuration menu
    Copy the full SHA
    cf7a88f View commit details
    Browse the repository at this point in the history