(PDK-373) Make test unit --list consistent with test unit #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pdk test unit` was using a pattern defined in puppetlabs_spec_helper while `pdk test unit --list` was using no pattern. This commit updates the --list option to use a puppetlabs_spec_helper rake task so it uses the same pattern.
austb
reviewed
Aug 2, 2017
lib/pdk/tests/unit.rb
Outdated
| next | ||
| end | ||
| if options.key?(:parallel) | ||
| json_result.push(PDK::Util.find_valid_json_in(result[:stdout])) |
There was a problem hiding this comment.
This will only get the first JSON result, but in parallel there will be many. I'll push a fix and an acceptance test.
There was a problem hiding this comment.
Apologies @austb I didn't realise that this was the point at which parallel results were actually gathered together
There was a problem hiding this comment.
No problem @james-stocks, just pushed a new acceptance test. And it made me realize that it can only parallelize when there are multiple spec files. So I learned something about what I did 👍
scotje
approved these changes
Aug 2, 2017
rodjek
added a commit
to rodjek/pdk
that referenced
this pull request
Nov 22, 2017
rodjek
added a commit
to rodjek/pdk
that referenced
this pull request
Nov 22, 2017
rodjek
added a commit
to rodjek/pdk
that referenced
this pull request
Nov 22, 2017
rodjek
added a commit
that referenced
this pull request
Nov 23, 2017
(maint) Update PDK::Test::Unit.parallel_with_no_tests? for PSH #216 changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pdk test unitwas using a pattern defined in puppetlabs_spec_helper whilepdk test unit --listwas using no pattern.This commit updates the --list option to use a puppetlabs_spec_helper rake task so it uses the same pattern.