(maint) Update PDK::Test::Unit.parallel_with_no_tests? for PSH #216 changes #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotje
approved these changes
Nov 22, 2017
| !result[:exit_code].zero? && | ||
| result[:stderr].strip =~ %r{Pass files or folders to run$} | ||
| ((!result[:exit_code].zero? && result[:stderr].strip =~ %r{Pass files or folders to run$}) || | ||
| result[:stderr].strip =~ %r{No files for parallel_spec to run against$}) |
There was a problem hiding this comment.
If this gets much more complicated it may merit some small predicate helper methods to increase legibility
There was a problem hiding this comment.
Yeah, it's getting a bit nasty isn't it? :)
chelnak
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavour of the parallel_spec rake task in puppetlabs_spec_helper changed in puppetlabs/puppetlabs_spec_helper#216. This PR updates our logic to detect no tests vs fail in
pdk test unit --parallel.