Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-475) Set BUNDLE_IGNORE_CONFIG for all commands #502

Merged
merged 1 commit into from
May 8, 2018

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented May 8, 2018

This will prevent any ~/.bundle/config or related config files that may exist from effecting how the PDK uses bundler.

Copy link
Contributor

@DavidS DavidS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me:

david@davids:~/tmp/blubb3$ pdk test unit
pdk (INFO): Using Ruby 2.4.4
pdk (INFO): Using Puppet 5.5.1
[✖] Preparing to run the unit tests.
pdk (ERROR): The spec_prep rake task failed with the following error(s):

/opt/puppetlabs/pdk/private/ruby/2.4.4/lib/ruby/gems/2.4.0/gems/bundler-1.16.1/lib/bundler/rubygems_integration.rb:458:in `block in replace_bin_path': can't find executable rake for gem rake. rake is not currently included in the bundle, perhaps you meant to add it to your Gemfile? (Gem::Exception)
	from /opt/puppetlabs/pdk/private/ruby/2.4.4/lib/ruby/gems/2.4.0/gems/bundler-1.16.1/lib/bundler/rubygems_integration.rb:489:in `block in replace_bin_path'
	from /home/david/tmp/blubb3/bin/rake:29:in `<main>'

[✖] Cleaning up after running unit tests.
pdk (ERROR): The spec_clean rake task failed with the following error(s):

/opt/puppetlabs/pdk/private/ruby/2.4.4/lib/ruby/gems/2.4.0/gems/bundler-1.16.1/lib/bundler/rubygems_integration.rb:458:in `block in replace_bin_path': can't find executable rake for gem rake. rake is not currently included in the bundle, perhaps you meant to add it to your Gemfile? (Gem::Exception)
	from /opt/puppetlabs/pdk/private/ruby/2.4.4/lib/ruby/gems/2.4.0/gems/bundler-1.16.1/lib/bundler/rubygems_integration.rb:489:in `block in replace_bin_path'
	from /home/david/tmp/blubb3/bin/rake:29:in `<main>'

pdk (FATAL): Failed to clean up after running unit tests
david@davids:~/tmp/blubb3$ cat .bundle/config 
---
BUNDLE_PATH: "~/gems"
BUNDLE_JOBS: "4"
BUNDLE_WITHOUT: "development"
david@davids:~/tmp/blubb3$ ~/git/pdk/bin/pdk test unit
pdk (INFO): Using Ruby 2.5.1
pdk (INFO): Using Puppet 5.5.1
[✔] Installing missing Gemfile dependencies.
[✔] Preparing to run the unit tests.
[✔] Running unit tests.
  Evaluated 5 tests in 0.042942744 seconds: 0 failures, 0 pending.
[✔] Cleaning up after running unit tests.
david@davids:~/tmp/blubb3$ ~/git/pdk/bin/pdk --version
1.6.0.pre (heads/pdk-475-0-geefced2)
david@davids:~/tmp/blubb3$ 

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 92.862% when pulling eefced2 on rodjek:pdk-475 into d1757f4 on puppetlabs:master.

@scotje scotje merged commit 43debfc into puppetlabs:master May 8, 2018
@rodjek rodjek deleted the pdk-475 branch May 14, 2018 05:54
@bmjen bmjen added the bug label Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants