(maint) Pin cri to <= 2.15.6 #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cri 2.15.7 changed the behaviour of the options hash so that unspecified flags are defaulted to an explicit `false` rather than being unset. From the look of denisdefreyne/cri#94 though this behaviour may be changing in the next release so lets pin cri to a maximum of 2.15.6 for now until the behaviour stabilises and then we can make the necessary changes. /cc puppetlabs#674
glennsarti
approved these changes
Jun 4, 2019
|
This PR makes sense, and I apologise for the trouble caused. I am working towards explicitly specifying all of Cri’s expected behavior, to minimize future disruption. For reference, here are the release notes for Cri 2.15.8 (unreleased): denisdefreyne/cri#100. Upgrading to Cri 2.15.8 will break the |
|
@ddfreyne Thank you for your quick response to this issue, we really appreciate your diligence as the maintainer of Cri! |
chelnak
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cri 2.15.7 changed the behaviour of the options hash so that unspecified
flags are defaulted to an explicit
falserather than being unset. Fromthe look of denisdefreyne/cri#94 though this
behaviour may be changing in the next release so lets pin cri to
a maximum of 2.15.6 for now until the behaviour stabilises and then we
can make the necessary changes.
/cc #674