Be less strict when using #hash_including with defaults #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces #hash_with_defaults_including, which is similar to RSpec’s built-in #hash_including, but does not require the keys of `expected` to be present in `actual` -- what matters is that for all keys in `expected`, the value in `actual` and `expected` is the same.
hash = Hash.new { |hash, key| 9000 }
moo(hash)
This passes:
expect(something)
.to receive(:moo)
.with(hash_with_defaults_including(stuff: 9000))
This does not pass:
expect(something)
.to receive(:moo)
.with(hash_including(stuff: 9000))
rodjek
added a commit
to rodjek/pdk
that referenced
this pull request
Jun 4, 2019
cri 2.15.7 changed the behaviour of the options hash so that unspecified flags are defaulted to an explicit `false` rather than being unset. From the look of denisdefreyne/cri#94 though this behaviour may be changing in the next release so lets pin cri to a maximum of 2.15.6 for now until the behaviour stabilises and then we can make the necessary changes. /cc puppetlabs#674
|
Need to make sure this is updated everywhere and we should remove the Cri pin as part of the same PR. |
|
Superseded by #731 |
logicminds
pushed a commit
to nwops/pdk
that referenced
this pull request
Nov 30, 2020
cri 2.15.7 changed the behaviour of the options hash so that unspecified flags are defaulted to an explicit `false` rather than being unset. From the look of denisdefreyne/cri#94 though this behaviour may be changing in the next release so lets pin cri to a maximum of 2.15.6 for now until the behaviour stabilises and then we can make the necessary changes. /cc puppetlabs#674
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces #hash_with_defaults_including, which is similar to RSpec’s built-in #hash_including, but does not require the keys of
expectedto be present inactual-- what matters is that for all keys inexpected, the value inactualandexpectedis the same.This passes:
This does not pass:
This is in preparation of landing denisdefreyne/cri#99, which makes use of these
Hashdefaults to specify default values for options.