(PDK-1384) Updates to be compatible with latest Cri #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are still a bunch of places where we call |
This PR introduces #hash_with_defaults_including, which is similar to RSpec's
built-in #hash_including, but does not require the keys of `expected` to be
present in `actual` -- what matters is that for all keys in `expected`, the
value in `actual` and `expected` is the same.
hash = Hash.new { |hash, key| 9000 }
moo(hash)
This passes:
expect(something)
.to receive(:moo)
.with(hash_with_defaults_including(stuff: 9000))
This does not pass:
expect(something)
.to receive(:moo)
.with(hash_including(stuff: 9000))
scotje
force-pushed
the
1384_cri_upgrade
branch
from
343ed77
to
d8de456
Compare
|
Tweaked |
|
Hrmm odd error in appveyor there. It's in the |
|
Yeah, I was trying to repro that in my VM yesterday, going to just re-kick the Appveyor build and see what happens.... |
|
Well it's happy now. 🤷♂ |
|
Ping @puppetlabs/pdk for review now that this is passing. |
glennsarti
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.