Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't attempt to modify a frozen string when parsing '--tests' paths #891

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Don't attempt to modify a frozen string when parsing '--tests' paths #891

merged 1 commit into from
Jul 15, 2020

Conversation

natemccurdy
Copy link
Contributor

@natemccurdy natemccurdy commented Jul 14, 2020 •
edited
Loading

Fixes issue #886

Prior to this, when specifying the path(s) to a spec file to test with the --tests option, PDK was failing with:

/pdk-1.18.0/lib/pdk/tests/unit.rb:96:in `tr!': can't modify frozen String (RuntimeError)

After this, pdk test unit --path some/spec/file.rb works and does not throw an error.

@natemccurdy natemccurdy requested a review from a team as a code owner July 14, 2020 22:06
@natemccurdy
Copy link
Contributor Author

This could use some tests.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.653% when pulling 91e2b68 on natemccurdy:issue/886/frozen_string into 3d6a310 on puppetlabs:master.

@joshcooper
Copy link

joshcooper commented Jul 14, 2020 •
edited
Loading

Tests are failing due to the default_env issue that rodjek/rspec-puppet#797 fixes. You'll need to rebase your PR after the other PR is merged

@scotje scotje merged commit 4c8ad15 into puppetlabs:master Jul 15, 2020
@natemccurdy natemccurdy deleted the issue/886/frozen_string branch July 15, 2020 16:32
@natemccurdy natemccurdy mentioned this pull request Jul 15, 2020
Closed
@scotje scotje added the bug label Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotje scotje scotje approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@natemccurdy @coveralls @joshcooper @scotje