796 Fix issues with puppet gem removal of default_env
#797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this is now changed to `DEFAULT_ENV`, we now create the old function alias to retain functionality. Bug: #796 Upstream: https://github.com/puppetlabs/puppet/blob/94df3c1a3992d89b2d7d5db8a70373c135bdd86b/lib/puppet/util.rb
scotje
approved these changes
Jul 14, 2020
|
Tested this locally and it allows |
sgnn7
added a commit
to cyberark/conjur-puppet
that referenced
this pull request
Jul 15, 2020
There were upstream issues with broken dependencies that we upstreamed a fix for and because of this we needed to pin to latest (unreleased) version of `rspec-puppet` gem. In the process, it seems like we also discovered that our fork was not required as the tests all pass so it was likely that we just had a fork to have a pre-release features ready which are now in mainline. Upstream bug: rodjek/rspec-puppet#796 Upstream fix: rodjek/rspec-puppet#797
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is now changed to
DEFAULT_ENV, we now create the oldfunction alias to retain functionality.
Bug: #796
Upstream: https://github.com/puppetlabs/puppet/blob/94df3c1a3992d89b2d7d5db8a70373c135bdd86b/lib/puppet/util.rb