Converts cudf over to supporting thrust existing in a nested namespace #11440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CMake
robertmaynard
force-pushed
the
thrust_namespace
branch
from
dc61bea
to
6a79eb4
Compare
github-actions
bot
removed
Python
robertmaynard
added
feature request
robertmaynard
commented
Aug 2, 2022
| @@ -585,6 +585,7 @@ target_include_directories( | |||
| target_compile_definitions( | |||
| cudf PUBLIC "$<$<COMPILE_LANGUAGE:CXX>:${CUDF_CXX_DEFINITIONS}>" | |||
| "$<BUILD_INTERFACE:$<$<COMPILE_LANGUAGE:CUDA>:${CUDF_CUDA_DEFINITIONS}>>" | |||
| PRIVATE "THRUST_WRAPPED_NAMESPACE=rapids" | |||
There was a problem hiding this comment.
This currently is PRIVATE on purpose since making it public would break consumers that use Thrust and don't call cudf API that have thrust types.
robertmaynard
force-pushed
the
thrust_namespace
branch
from
6a79eb4
to
639f4f4
Compare
robertmaynard
force-pushed
the
thrust_namespace
branch
from
639f4f4
to
6f95f10
Compare
|
This PR has been labeled |
|
Closing this as we are going to use a different approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is one way that cudf can be updated to support a nested version of thrust.
This version requires rapidsai/rmm#1077
Tasks
Checklist