-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support using THRUST_WRAPPED_NAMESPACE #1077
Support using THRUST_WRAPPED_NAMESPACE #1077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions.
include/rmm/device_vector.hpp
Outdated
#ifdef THRUST_WRAPPED_NAMESPACE | ||
using namespace THRUST_WRAPPED_NAMESPACE; | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For simplicity and tidiness, could these 3 lines just be put in a header that all RMM headers include?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you choose which headers to put this in? Is it needed in the ones that do not use Thrust like cuda_async_memory_resource.hpp
?
If it is needed everywhere, you could put it in the base MR header (device_memory_resource.hpp
) then all MR headers would include it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic only needs to be placed in headers that explicitly include
thrust headers.
Given that rmm has 8 headers that include thrust, refactoring to a common header seems wise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the pr to move the shared logic to thrust_namespace.h
This PR has been labeled |
46b2835
to
ebe9f11
Compare
@gpucibot merge |
Allows rmm to be used in the presence of
THRUST_WRAPPED_NAMESPACE
which changes the namespace location of all thrust types.