Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade dlpack to 0.5 #8262

Merged
merged 32 commits into from
May 25, 2021
Merged

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented May 17, 2021

Update dlpack from 0.3 to >=0.5,<0.6.0a0, and fix for breaking changes introduced in 0.4.

closes #7679

@cwharris cwharris added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels May 17, 2021
@cwharris cwharris requested a review from a team as a code owner May 17, 2021 16:31
@cwharris cwharris added the feature request New feature or request label May 17, 2021
@github-actions github-actions bot added the CMake CMake build issue label May 17, 2021
@cwharris
Copy link
Contributor Author

waiting for conda-forge to get updated with dlpack 0.5 so I can test.

@cwharris cwharris added 0 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team labels May 17, 2021
@kkraus14 kkraus14 added 2 - In Progress Currently a work in progress and removed 0 - Waiting on Author Waiting for author to respond to review labels May 17, 2021
@cwharris cwharris requested review from a team as code owners May 18, 2021 15:08
@cwharris cwharris requested a review from mythrocks May 18, 2021 15:08
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves the errors I was seeing. Thanks @cwharris !

cpp/tests/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@cwharris, could we consider updating this PR's description with a very brief description of #7679, indicating that dmlc/dlpack had a breaking change in 0.3-0.4?
I suspect the git log commit message will be more informative then.

@github-actions github-actions bot removed the gpuCI label May 24, 2021
@github-actions github-actions bot added the gpuCI label May 24, 2021
@github-actions github-actions bot removed the gpuCI label May 25, 2021
@cwharris cwharris added 5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working and removed 2 - In Progress Currently a work in progress feature request New feature or request labels May 25, 2021
@jakirkham
Copy link
Member

Guessing this will eventually run into the Python test failures we are fixing in PR ( #8342 ). So this may need an admin merge (though probably worth waiting to make sure those are the only failures on CI)

@cwharris
Copy link
Contributor Author

Looks like we're failing due to the errors which will be fixed by #8342 .

17:29:55 Traceback (most recent call last):
17:29:55   File "<string>", line 1, in <module>
17:29:55   File "/workspace/.conda-bld/dask-cudf_1621981592845/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.8/site-packages/dask_cudf/__init__.py", line 6, in <module>
17:29:55     from . import backends
17:29:55   File "/workspace/.conda-bld/dask-cudf_1621981592845/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.8/site-packages/dask_cudf/backends.py", line 9, in <module>
17:29:55     from dask.dataframe.core import get_parallel_type, make_meta, meta_nonempty
17:29:55 ImportError: cannot import name 'make_meta' from 'dask.dataframe.core' (/workspace/.conda-bld/dask-cudf_1621981592845/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.8/site-packages/dask/dataframe/core.py)

@cwharris
Copy link
Contributor Author

@kkraus14 Ok to do an admin merge here?

@kkraus14 kkraus14 merged commit eea8cab into rapidsai:branch-21.06 May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Support dlpack >= 0.4
9 participants