[REVIEW] Add support for make_meta_obj dispatch in dask-cudf
#8342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
bug
jakirkham
approved these changes
May 25, 2021
|
rerun tests |
This PR is dependent on dask upstream changes: dask/dask#7586 |
kkraus14
approved these changes
May 25, 2021
2 tasks
|
rerun tests |
galipremsagar
added
5 - Ready to Merge
|
@gpucibot merge |
|
Looks like the build is failing on the C++ side due to the DLPack issue being addressed in PR ( #8262 ) |
This was referenced May 25, 2021
Merged
|
rerun tests |
|
@gpucibot merge |
|
The failure here is coming from Dask-CUDA, which will be fixed with PR ( rapidsai/dask-cuda#623 ). However that PR also requires this PR to pass. Looks like we may need an admin merge here as well |
yeah cc: @kkraus14 |
rapids-bot bot
pushed a commit
to rapidsai/dask-cuda
that referenced
this pull request
May 26, 2021
Requires PR ( rapidsai/cudf#8342 ) As these functions recently got relocated, handle `import`ing from the new location with a fallback to the old location. xref: dask/dask#7503 xref: dask/dask#7505 Authors: - https://github.com/jakirkham Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Benjamin Zaitlen (https://github.com/quasiben) URL: #623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7946
This PR is dependent on upstream dask changes that are needed for a portion of the fix: https://github.com/dask/dask/pull/7586/files
This PR includes changes to introduce
make_meta_objwhich will ensure proper metadata is retrieved from the parent_meta being passed in the upstream PR.