Drop Python 3.9 support #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
non-breaking
jameslamb
commented
Aug 22, 2024
| @@ -27,15 +27,11 @@ authors = [ | |||
| { name = "NVIDIA Corporation" }, | |||
| ] | |||
| license = { text = "Apache 2.0" } | |||
| requires-python = ">=3.6" | |||
| requires-python = ">=3.10" | |||
There was a problem hiding this comment.
@alexbarghi-nv was it intentional that pylibwholegraph has a floor of Python 3.6? It's not being tested against such an old version, but I'm wondering if that was intentionally kept here to support some alternative builds or something.
There was a problem hiding this comment.
I believe it was for a specific reason. @linhu-nv would probably know more.
There was a problem hiding this comment.
I think there is no specific reason for this. Maybe this is because that this hasn't been updated for a long time. Wholegraph works with python3.10 well. So I think we can update the python version as other rapidsai projects.
This was referenced Aug 22, 2024
bdice
approved these changes
Aug 23, 2024
alexbarghi-nv
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#88
Finishes the work of dropping Python 3.9 support.
This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.
Notes for Reviewers
How I tested this
Checked that there were no remaining uses like this:
And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).