Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.9 support #32

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Drop Python 3.9 support #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9db217
Drop Python 3.9 support
jameslamb Aug 22, 2024
d2d9028
update requires-python floor in pylibwholegraph
jameslamb Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/src/wholememory/communicator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1065,4 +1065,4 @@ wholememory_error_code_t communicator_set_distributed_backend(
WHOLEMEMORY_FAIL_NOTHROW("Unknown exception.");
}
}
} // namespace wholememory
} // namespace wholememory
6 changes: 1 addition & 5 deletions dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,6 @@ dependencies:
specific:
- output_types: [conda]
matrices:
- matrix:
py: "3.9"
packages:
- python=3.9
- matrix:
py: "3.10"
packages:
Expand All @@ -245,7 +241,7 @@ dependencies:
- python=3.11
- matrix:
packages:
- python>=3.9,<3.12
- python>=3.10,<3.12
python_build_wheel:
common:
- output_types: [conda, pyproject, requirements]
Expand Down
2 changes: 1 addition & 1 deletion python/cugraph-dgl/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ authors = [
{ name = "NVIDIA Corporation" },
]
license = { text = "Apache 2.0" }
requires-python = ">=3.9"
requires-python = ">=3.10"
classifiers = [
"Intended Audience :: Developers",
"Programming Language :: Python",
Expand Down
3 changes: 1 addition & 2 deletions python/cugraph-pyg/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,10 @@ authors = [
{ name = "NVIDIA Corporation" },
]
license = { text = "Apache 2.0" }
requires-python = ">=3.9"
requires-python = ">=3.10"
classifiers = [
"Intended Audience :: Developers",
"Programming Language :: Python",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
]
Expand Down
6 changes: 1 addition & 5 deletions python/pylibwholegraph/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,11 @@ authors = [
{ name = "NVIDIA Corporation" },
]
license = { text = "Apache 2.0" }
requires-python = ">=3.6"
requires-python = ">=3.10"
Copy link
Member Author

@jameslamb jameslamb Aug 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexbarghi-nv was it intentional that pylibwholegraph has a floor of Python 3.6? It's not being tested against such an old version, but I'm wondering if that was intentionally kept here to support some alternative builds or something.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it was for a specific reason. @linhu-nv would probably know more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is no specific reason for this. Maybe this is because that this hasn't been updated for a long time. Wholegraph works with python3.10 well. So I think we can update the python version as other rapidsai projects.

classifiers = [
"Intended Audience :: Developers",
"License :: OSI Approved :: Apache Software License",
"Programming Language :: Python",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
]
Expand Down