Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support innerproduct distance in the pairwise_distance API #5230

Merged
merged 4 commits into from
Feb 14, 2023
Merged

Support innerproduct distance in the pairwise_distance API #5230

merged 4 commits into from
Feb 14, 2023

Conversation

benfred
Copy link
Member

@benfred benfred commented Feb 10, 2023 •
edited by vyasr
Loading

Fixes for supporting InnerProduct distance in the pairwise_distance api - required to handle the changes in rapidsai/raft#1226.

Also resolves #4078. That fix was necessary to tack on to this PR due to upstream RAPIDS updates to the spdlog version (in rmm via rapids-cmake).

@benfred benfred requested a review from a team as a code owner February 10, 2023 22:30
@benfred benfred mentioned this pull request Feb 10, 2023
Merged
@benfred benfred requested a review from a team as a code owner February 11, 2023 00:01
cjnolet
cjnolet approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's a couple places in HDBSCAN where we're calling the pairwise distances API directly from RAFT. Otherwise, this LGTM, pending the revert in get_raft.cmake and CI.

cpp/cmake/thirdparty/get_raft.cmake Outdated Show resolved Hide resolved
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 11, 2023
@benfred benfred changed the title test out innerproduct pairwise_distances changes Support innerproduct distance in the pairwise_distance API Feb 13, 2023
@cjnolet
Copy link
Member

cjnolet commented Feb 13, 2023

/merge

@vyasr vyasr mentioned this pull request Feb 13, 2023
Merged
@ajschmidt8 ajschmidt8 requested review from a team as code owners February 13, 2023 18:57
@benfred
Support innerproduct distance in the pairwise_distance API
4eb6ba2 
Fixes for supporting InnerProduct distance in the pairwise_distance api - required to handle the changes in rapidsai/raft#1226
@ajschmidt8 ajschmidt8 removed the request for review from a team February 13, 2023 22:13
@vyasr vyasr mentioned this pull request Feb 14, 2023
Closed
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 14, 2023
@rapids-bot rapids-bot bot merged commit df3aee9 into rapidsai:branch-23.04 Feb 14, 2023
@benfred benfred deleted the test_inner_product branch February 14, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@benfred benfred

Labels
CMake CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Compile error from spdlog 1.9
3 participants
@benfred @cjnolet @vyasr