[BUG] Compile error from spdlog 1.9

[cjnolet]

We have found the following build error in a couple logs (and in CI now) which seems to stem from spdlog recently deploying updated conda packages.

/home/cjnolet/miniconda3/envs/cuml_2108_072021_3/include/spdlog/fmt/bundled/format-inl.h: In function ‘std::system_error fmt::v8::vsystem_error(int, fmt::v8::string_view, fmt::v8::format_args)’:
/home/cjnolet/miniconda3/envs/cuml_2108_072021_3/include/spdlog/fmt/bundled/format-inl.h:135:8: error: expected primary-expression before ‘class’
  135 |   return std::system_error(ec, vformat(format_str, args));
      |        ^~~~~
/home/cjnolet/miniconda3/envs/cuml_2108_072021_3/include/spdlog/fmt/bundled/format-inl.h:135:7: error: expected ‘;’ before ‘class’
  135 |   return std::system_error(ec, vformat(format_str, args));
      |       ^~~~~~
      |       ;
/home/cjnolet/miniconda3/envs/cuml_2108_072021_3/include/spdlog/fmt/bundled/format-inl.h:135:8: error: expected primary-expression before ‘class’
  135 |   return std::system_error(ec, vformat(format_str, args));
      |        ^~~~~
/home/cjnolet/miniconda3/envs/cuml_2108_072021_3/include/spdlog/fmt/bundled/format-inl.h: In function ‘void fmt::v8::format_system_error(fmt::v8::detail::buffer<char>&, int, const char*)’:
/home/cjnolet/miniconda3/envs/cuml_2108_072021_3/include/spdlog/fmt/bundled/format-inl.h:2545:32: error: expected primary-expression before ‘class’
 2545 |     write(std::back_inserter(out), std::system_error(ec, message).what());
      |                                ^~~~~
make[2]: *** [test/CMakeFiles/ml.dir/build.make:580: test/CMakeFiles/ml.dir/sg/umap_parametrizable_test.cu.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:1267: test/CMakeFiles/ml.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

It's strange the compile error is in an spdlog header. I did notice the spdlog readme mentions building w/ c++11.

[cjnolet]

We've agreed to pin to spdlog 1.8.5 for now to get through release 21.08 and revist.

[github-actions]

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

[github-actions]

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

[vyasr]

I just encountered this again with the recent changes to spdlog and fmt. The problem looks to be due to a using namespace std in a test where some names were being clobbered. I've fixed that in 201e265 as part of #5230.