[REVIEW] Pinning spdlog because recent updates are causing compile issues. #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun tests (download error) |
|
The original issue for was created in the cuml project (since it was
directly affecting CI there): rapidsai/cuml#4078.
…On Wed, Jul 21, 2021 at 4:38 PM Gabi Melman ***@***.***> wrote:
What are the compilation issues?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#831 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJPKYDT3SKHI7IRIQXJQRLTY4V2ZANCNFSM5AYPND6A>
.
|
harrism
approved these changes
Jul 21, 2021
|
This matches the version used in cmake, so seems fine. |
jolorunyomi
approved these changes
Jul 21, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 23, 2021
Follow up to #831, this pins spdlog in the dev conda envs too. Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - https://github.com/jakirkham - GALI PREM SAGAR (https://github.com/galipremsagar) - Jordan Jacobelli (https://github.com/Ethyling) URL: #835
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spdlog 1.9 conda package was released yesterday and it's causing compile issues on cuml. We're also pinning it in the integrations repo: rapidsai/integration#318.