This repository has been archived by the owner on Sep 25, 2023. It is now read-only.
[RELEASE] cusignal v22.06 #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[gpuCI] Forward-merge branch-22.04 to branch-22.06 [skip gpuci]
- Adjusts the installation section for the RTL-SDR example notebook to properly install all of the NeMo ASR toolkit dependencies as well as SoapySDR with RTL-SDR support - Installs pyaudio + SoapySDR with LimeSDR support for the general SDR example notebook - Adds a disclaimer to both notebooks that they will not work without an SDR device connected Closes #469 Closes #470 Authors: - Charles Blackmon-Luca (https://github.com/charlesbluca) Approvers: - Adam Thompson (https://github.com/awthomp) URL: #476
This PR makes some changes to `get_pinned_mem` so that it properly handles dtypes other than `uint8` - it also adds some additional handling for `shape` so that integers are now supported, and the output array actually has the input `shape`. Authors: - Charles Blackmon-Luca (https://github.com/charlesbluca) Approvers: - Adam Thompson (https://github.com/awthomp) URL: #477
This PR resolve pinned buffer IO issues introduced in de9be48; essentially, if `read_bin` is passed a `buffer` and `dtype`, it should prioritize `buffer.dtype` over `dtype` to ensure that the buffer and memmap sizes match up. Still want to add IO tests to ensure that things are working properly, and potentially alter `read_bin` to raise an error if both `buffer` and `dtype` are provided. Closes #474 Authors: - Charles Blackmon-Luca (https://github.com/charlesbluca) Approvers: - Adam Thompson (https://github.com/awthomp) URL: #479
This PR adds a [pre-commit](https://pre-commit.com/) configuration to this repo to enforce the Python style checks - it also modifies the gpuCI style check to use pre-commit instead of just `isort`. The pre-commit configuration can probably be expanded to include CUDA style enforcement with `clang-format`, but this seemed like a decent starting point. Authors: - Charles Blackmon-Luca (https://github.com/charlesbluca) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Adam Thompson (https://github.com/awthomp) URL: #478
This PR convert the `from sources` build we are doing in GPU test job to a `conda build`. This is done for the following reasons: - This is required step to improve the Ops CI/CD setup to a more convenient pipeline - This is required to start using `conda` compilers and `mamba` to build RAPIDS packages - This prevent us from manually managing and installing the dependencies in GPU job - This ensure the packages can be installed - This ensure the tests are running and working against the package content and not the build results. Currently the Python packages are not tested. This may increase the global pipeline time, but the usage of `mamba` should resolve this as `mamba` is faster than `conda` to build packages Authors: - Jordan Jacobelli (https://github.com/Ethyling) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Brad Rees (https://github.com/BradReesWork) URL: #480
This PR enables the usage of conda compilers to build conda packages. This is required to use `mambabuild` Authors: - Jordan Jacobelli (https://github.com/Ethyling) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) URL: #461
Simplify recipes using `{{ target_platform }}` for `sysroot` package and `compiler()` function in `ignore_run_exports_from`
Authors:
- Jordan Jacobelli (https://github.com/Ethyling)
Approvers:
- AJ Schmidt (https://github.com/ajschmidt8)
URL: #484
Use `mambabuild` to build `conda` packages. This should speed up the builds and help to debug `conda` conflict issues Authors: - Jordan Jacobelli (https://github.com/Ethyling) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) URL: #453
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❄️ Code freeze for
branch-22.06and v22.06 releaseWhat does this mean?
Only critical/hotfix level issues should be merged into
branch-22.06until release (merging of this PR).What is the purpose of this PR?
branch-22.06intomainfor the release