Handle keepalive #76
Handle keepalive #76
Conversation
| @@ -6,54 +6,88 @@ | |||
| use React\Socket\ServerInterface as SocketServerInterface; | |||
| use React\Socket\ConnectionInterface; | |||
|
|
|||
|
|
|||
| class ConnProxy { | |||
There was a problem hiding this comment.
Could you extract this into it's own file
There was a problem hiding this comment.
Thanks for filing this PR, I'd really like to see this feature in 👍
Unfortunately I do not think this is reasonable in its current state, given that we have not implemented chunked transfer encoding (#96) yet.
Connection reuse requires being able to detect exact message boundaries, which in turn requires handling explicit message lengths, chunked transfer encoding and implicit message lengths. (This is covered in detail in https://tools.ietf.org/html/rfc7230#section-3.3)
As much as I'd like to get this feature in, I'm not sure reviewing this in depth currently makes much sense 👍
|
As much as I'd love to get this feature in, I'm having to close this for now as it hasn't received any input in a while and it's unlikely this will get traction any time soon. The feature request is still open in #39 and we'll look into this in the not too far future 👍 If you feel this was closed prematurely or want to pick this up again, please let us know and we can reopen this. Thank you for your effort! |
Hi,
I see a previous keepalive pull request opened for some time now.
Here is another one I made.
I find it clearer than the previous one because the connection is maintained/closed according to request header and a max number of reuse of the connection.
I've done some tests with apache benchark on a virtual machine and I'm getting an average of 1.6x requests/s with keepalive.
By the way testing with PHP 7.0.8 shows that the connexion shouldn't be reused too many times. I set it as a constant in the code to 25. Increasing this number shows a drop in speed, I havent managed to understand why...
Closes #39