Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(dev/cli): Add --port flag to remix dev #3447

Merged
merged 1 commit into from
Jun 11, 2022
Merged

Conversation

chaance
Copy link
Collaborator

@chaance chaance commented Jun 10, 2022

This PR adds a --port flag to remix dev that takes precedence over process.env.PORT. This makes it easier to choose a new port on the fly.

Note, I updated the snapshot but didn't create any new tests yet. We don't currently have a test suite for remix dev commands and I need to follow up internally before adding a new process-intensive test that could further slow things down in CI. I did test it manually and things work as expected.

@chaance chaance merged commit cc9e5c3 into dev Jun 11, 2022
@chaance chaance deleted the chance/cli-port branch June 11, 2022 05:27
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v1.6.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v1.6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.

Comment on lines +237 to +241
export async function dev(
remixRoot: string,
modeArg?: string,
portArg?: number
) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need to add one more arg to this in the future let's turn this into a single options argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants