Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remix-dev): declare --port & -p flags #3694

Merged
merged 1 commit into from
Jul 10, 2022
Merged

fix(remix-dev): declare --port & -p flags #3694

merged 1 commit into from
Jul 10, 2022

Conversation

machour
Copy link
Collaborator

@machour machour commented Jul 10, 2022

It seems that we forgot to declare it in #3447

Closes #3693

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2022

⚠️ No Changeset found

Latest commit: 8e6ddf5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@machour machour requested a review from chaance July 10, 2022 11:46
@machour machour changed the title chore: update and sync deps fix(remix-dev): Declare the --port flag for arg Jul 10, 2022
@machour machour linked an issue Jul 10, 2022 that may be closed by this pull request
remix dev --port doesn't work #3693
Closed
@MichaelDeBoey MichaelDeBoey changed the title fix(remix-dev): Declare the --port flag for arg fix(remix-dev): declare --port & -p flags Jul 10, 2022
@chaance chaance merged commit 540af5a into remix-run:dev Jul 10, 2022
@machour machour deleted the fix/3693-dev-port-flag branch July 10, 2022 19:59
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-7a4e17f-20220711 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@MichaelDeBoey MichaelDeBoey mentioned this pull request Jul 11, 2022
Closed
This was referenced Jul 13, 2022
Merged
Merged
@mcansh mcansh mentioned this pull request Jan 10, 2023
Closed
@Varedis Varedis mentioned this pull request Mar 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaance chaance chaance approved these changes

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees
No one assigned
Labels
CLA Signed package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remix dev --port doesn't work
3 participants
@machour @chaance @MichaelDeBoey