fix: correctly infer deferred types for top-level promises #7104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 67e7729 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
pcattori
commented
Aug 8, 2023
Comment on lines
-8
to
-31
| isEqual<SerializeFrom<string>, string>(true); | ||
| isEqual<SerializeFrom<number>, number>(true); | ||
| isEqual<SerializeFrom<boolean>, boolean>(true); | ||
| isEqual<SerializeFrom<String>, String>(true); | ||
| isEqual<SerializeFrom<Number>, Number>(true); | ||
| isEqual<SerializeFrom<Boolean>, Boolean>(true); | ||
| isEqual<SerializeFrom<null>, null>(true); | ||
|
|
||
| isEqual<IsNever<SerializeFrom<undefined>>, true>(true); | ||
| isEqual<IsNever<SerializeFrom<Function>>, true>(true); | ||
| isEqual<IsNever<SerializeFrom<symbol>>, true>(true); | ||
|
|
||
| isEqual<SerializeFrom<[]>, []>(true); | ||
| isEqual<SerializeFrom<[string, number]>, [string, number]>(true); | ||
| isEqual<SerializeFrom<[number, number]>, [number, number]>(true); | ||
|
|
||
| isEqual<SerializeFrom<ReadonlyArray<string>>, string[]>(true); | ||
| isEqual<SerializeFrom<ReadonlyArray<Function>>, null[]>(true); | ||
|
|
||
| isEqual<SerializeFrom<{ hello: "remix" }>, { hello: "remix" }>(true); | ||
| isEqual< | ||
| SerializeFrom<{ data: { hello: "remix" } }>, | ||
| { data: { hello: "remix" } } | ||
| >(true); |
There was a problem hiding this comment.
Since we're using type-fest's Jsonify now, these tests are no longer testing Remix code.
pcattori
force-pushed
the
pedro/fix-defer-types
branch
2 times, most recently
from
d4d6128
to
a134ba9
Compare
pcattori
force-pushed
the
pedro/fix-defer-types
branch
from
46c5513
to
0ffe817
Compare
github-actions
bot
added
the
awaiting release
1 task
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5427