Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): get deps from ESM packages without main #7272

Merged
merged 3 commits into from
Aug 28, 2023
Merged

fix(dev): get deps from ESM packages without main #7272

merged 3 commits into from
Aug 28, 2023

Conversation

markdalgleish
Copy link
Member

This PR adds some extra logic to getDependenciesToBundle to handle the case where an ESM package doesn't provide an export for "./" but provides one for "./package.json".

Closes #3106

  • Docs
  • Tests

@markdalgleish markdalgleish added package:dev v2 Issues related to v2 apis labels Aug 28, 2023
@markdalgleish markdalgleish self-assigned this Aug 28, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 31dd297

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish merged commit 9154f35 into dev Aug 28, 2023
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/esm-without-main branch August 28, 2023 21:28
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Aug 28, 2023
@markdalgleish markdalgleish mentioned this pull request Aug 28, 2023
Closed
2 tasks
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-9154f35-20230829 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@KarelVerschraegen KarelVerschraegen mentioned this pull request Sep 12, 2023
Closed
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-e3d5b17-20230916 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Sep 21, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Sep 21, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Sep 21, 2023
@buildtheui buildtheui mentioned this pull request Oct 10, 2023
Merged
sergiodxa pushed a commit to sergiodxa/remix-utils that referenced this pull request Oct 11, 2023
@buildtheui
Convert remix-utils to regex on serverDependenciesToBundle (#254)
dc1dfcc 
While attempting to upgrade Remix Utils to the latest version, I
encountered the following error:
```
Error [ERR_REQUIRE_ESM]: require() of ES Module ... Instead change the require of promise.js 
``` 
Diving deeper I realized that the error was due to my oversight. I had
overlooked the warning to _add each individual utility_ to the
serverDependenciesToBundle configuration. Subsequently, I also noticed
that a related pull request
([PR](remix-run/remix#7272)) had been merged
into Remix version
[2.0.1](https://github.com/remix-run/remix/releases/tag/remix%402.0.1)
but had not completely resolved the issue.

By adding `/^remix-utils.*/,` in lieu of `"remix-utils"` and every
individual util to `serverDependenciesToBundle`, it stops showing the
error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees

@markdalgleish markdalgleish

Labels
CLA Signed package:dev v2 Issues related to v2 apis
Projects
No open projects
v2
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markdalgleish @MichaelDeBoey