debuginfo: Make DW_TAG_subroutine DIEs for inherent methods children of their self-type DIEs. #33358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jroesch (rust_highfive has picked a reviewer for you, use r? to override) |
| index: cx.tcx() | ||
| .def_key(instance.def) | ||
| .parent | ||
| .expect("get_namespace_and_span_for_item: missing parent?") |
There was a problem hiding this comment.
This needs to be get_containing_scope_and_span instead.
|
☔ The latest upstream changes (presumably #33425) made this pull request unmergeable. Please resolve the merge conflicts. |
…of their self-type DIEs.
michaelwoerister
force-pushed
the
debuginfo-methods
branch
from
3127fc4
to
499605c
Compare
|
Rebased and fixed the error kindly pointed out by @sanxiyn. |
|
@bors r+ |
|
📌 Commit 499605c has been approved by |
bors
added a commit
that referenced
this pull request
May 20, 2016
debuginfo: Make DW_TAG_subroutine DIEs for inherent methods children of their self-type DIEs. Fixes #33192
bors
added a commit
that referenced
this pull request
Aug 26, 2016
Do not emit "class method" debuginfo for types that are not DICompositeType. Fixes #35991 by restricting the "class method" debuginfo sugar from #33358 to structs and enums only. r? @michaelwoerister
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33192