Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not emit "class method" debuginfo for types that are not DICompositeType. #36008

Merged
merged 1 commit into from
Aug 27, 2016

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Aug 26, 2016

Fixes #35991 by restricting the "class method" debuginfo sugar from #33358 to structs and enums only.

r? @michaelwoerister

@michaelwoerister
Copy link
Member

cc @tromey: It seems like LLVM doesn't allow us to put methods on non-class types. Does the current version GDB rely on that in any way yet?

@michaelwoerister
Copy link
Member

@bors r+

Since LLVM does not allow this anymore, there's little we can do in the short term. In the long term, we'll need a different strategy for associating methods with their self types anyway, since this one doesn't scale to trait methods.

@bors
Copy link
Contributor

bors commented Aug 26, 2016

📌 Commit 8407952 has been approved by michaelwoerister

@alexcrichton
Copy link
Member

@bors: p=10

(fixing nightlies)

@tromey
Copy link
Contributor

tromey commented Aug 26, 2016

It seems like LLVM doesn't allow us to put methods on non-class types. Does the current version GDB rely on that in any way yet?

No. IIRC this was just in our draft proposal for how interface impls ought to be represented, not anything that was actually implemented (or even actually proposed)?

@michaelwoerister
Copy link
Member

@tromey Good, so this doesn't make things worse at least.

@bors
Copy link
Contributor

bors commented Aug 26, 2016

⌛ Testing commit 8407952 with merge 1987131...

bors added a commit that referenced this pull request Aug 26, 2016
Do not emit "class method" debuginfo for types that are not DICompositeType.

Fixes #35991 by restricting the "class method" debuginfo sugar from #33358 to structs and enums only.

r? @michaelwoerister
@bors bors merged commit 8407952 into rust-lang:master Aug 27, 2016
@eddyb eddyb deleted the compound-fail branch August 27, 2016 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants