rustdoc: fix emitting duplicate implementors in .js files #33509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The collect() fn checks for double quotes; use them here as well. Fixes: rust-lang#30219
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -783,7 +783,7 @@ fn write_shared(cx: &Context, | |||
| try_err!(write!(&mut f, "{}", *implementor), &mydst); | |||
| } | |||
|
|
|||
| try_err!(write!(&mut f, r"implementors['{}'] = [", krate.name), &mydst); | |||
| try_err!(write!(&mut f, r#"implementors["{}"] = ["#, krate.name), &mydst); | |||
There was a problem hiding this comment.
I'm wondering if it wouldn't be better to just use escaped double quotes...
There was a problem hiding this comment.
I don't mind. I was being consistent with https://github.com/birkenfeld/rust/blob/issue-30219/src/librustdoc/html/render.rs#L729
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 9, 2016
rustdoc: fix emitting duplicate implementors in .js files The collect() fn checks for double quotes; use them here as well. Fixes: rust-lang#30219
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 9, 2016
rustdoc: fix emitting duplicate implementors in .js files The collect() fn checks for double quotes; use them here as well. Fixes: rust-lang#30219
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 9, 2016
rustdoc: fix emitting duplicate implementors in .js files The collect() fn checks for double quotes; use them here as well. Fixes: rust-lang#30219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The collect() fn checks for double quotes; use them here as well.
Fixes: #30219